fix(opencode): make dispatch wait for child tasks#147
Open
1508324011 wants to merge 3 commits intomindfold-ai:mainfrom
Open
fix(opencode): make dispatch wait for child tasks#1471508324011 wants to merge 3 commits intomindfold-ai:mainfrom
1508324011 wants to merge 3 commits intomindfold-ai:mainfrom
Conversation
Switch the OpenCode dispatch instructions to synchronous child Task calls so Trellis stops treating the background wrapper as the true completion signal for subagent phases. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Lock in the OpenCode dispatch behavior change so future template edits cannot quietly reintroduce background TaskOutput polling for child phases. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Document that Trellis OpenCode dispatch must wait for child Task calls to return instead of using background task status as the final completion signal. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Author
|
Follow-up note: after more testing, I no longer think this PR should be described as a complete fix. It still looks useful as a mitigation because it removes one error-prone dispatch pattern in the OpenCode template. But in longer conversations, the underlying background completion semantics can still be wrong even when the prompt says to use synchronous child calls. So this PR is better framed as a patch / risk reduction step, while the root cause is likely in the lower-level I opened a follow-up issue to track that root problem separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task(...)calls instead of backgroundTaskOutputpollingrun_in_background: truechild phasesTesting