Skip to content

Conversation

ZoranPandovski
Copy link
Member

This PR:

  1. Adds support for Python 3.12
  2. Deprecates Python 3.8 and 3.9
  3. Bump version for release

NOTE: We are reverting to semantic versioning

Copy link

Review Summary

Skipped posting 2 drafted comments based on your review threshold. Feel free to update them here.

Draft Comments
.github/workflows/python-package.yml:21-23
The GitHub Actions checkout and setup-python actions are using older v2 versions which may lack newer features and security updates. Consider upgrading to the latest versions.

Scores:

  • Production Impact: 2
  • Fix Specificity: 5
  • Urgency Impact: 2
  • Total Score: 9

Reason for filtering: The total score is below the threshold of 13 required for inclusion

Analysis: While the fix is very specific and easy to implement (updating GitHub Actions versions), the production impact is low as older versions still function. The urgency is also low since this is a maintenance improvement rather than a critical security vulnerability. The total score of 9 falls below the required threshold of 13.

.github/workflows/python-package.yml:49-51
The deployment job is also using outdated GitHub Actions. Updating to the latest versions ensures better compatibility with Python 3.12 and improved security.

Scores:

  • Production Impact: 2
  • Fix Specificity: 5
  • Urgency Impact: 3
  • Total Score: 10

Reason for filtering: The total score is below the required threshold of 13 for inclusion

Analysis: While the fix is very specific and directly applicable (5), the production impact is relatively low (2) as outdated GitHub Actions typically don't cause immediate production failures. The urgency is medium (3) as updating Actions is important for security but not critical for immediate system functionality. Total score of 10 falls below the required threshold of 13.

@github-project-automation github-project-automation bot moved this from to review to approved in Tracking PRs May 5, 2025
@ZoranPandovski ZoranPandovski merged commit e35cd78 into staging May 5, 2025
8 checks passed
@ZoranPandovski ZoranPandovski deleted the py3.12-support branch May 5, 2025 11:11
@github-project-automation github-project-automation bot moved this from approved to merged in Tracking PRs May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

2 participants