Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishbone: Convert to the wishbone_soc interfacing, for better interoperability #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

galibert
Copy link
Contributor

@galibert galibert commented Feb 5, 2023

The main difference is that the wishbone-soc Arbiter is round-robin, while minerva's current is priority. Not sure if it matters. If it does, I'll try to enhance w-soc's.

@@ -4,7 +4,7 @@

from amaranth import *
from amaranth.lib.coding import PriorityEncoder

from amaranth_soc import wishbone
Copy link
Collaborator

@whitequark whitequark Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a line in install_requires in setup.py... amaranth-soc didn't have a release yet, so probably something like amaranth-soc @ https://github.com/amaranth-lang/amaranth-soc.git

@jfng
Copy link
Member

jfng commented Feb 6, 2023

The main difference is that the wishbone-soc Arbiter is round-robin, while minerva's current is priority. Not sure if it matters. If it does, I'll try to enhance w-soc's.

Minerva uses a read-only D-cache, alongside a write buffer (to allow early retirement of store operations). When a load causes a D-cache miss, the write buffer must be emptied to commit ongoing store operations, before starting a cache refill. The data bus arbiter is responsible for this, with a priority-based round-robin policy.

The instruction bus arbiter does not require a priority-based policy, but I'd prefer to reuse the same implementation for convenience, unless the upstream one is significantly lighter.

Could you adapt this PR to keep Minerva's WishboneArbiter and update setup.py ? LGTM otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants