Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move center to marker when clicked #388

Conversation

Emojigit
Copy link
Contributor

@Emojigit Emojigit commented Jun 7, 2024

This PR adds code to move the center of the canvas to where it is when a marker is clicked. There are some limitations:

  • Only AbstractIconOverlay is supported. I am too lazy to make others because the implementation differs between non-AbstractIconOverlay markers.
  • If moving the map results in loading new tiles, the movement may be disturbed. The reason is still unknown.

As usual, this PR can be tested on my map server. This PR is ready for review. And yeah, I used 10 commits before eventually passing the finish line.

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9419841347

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.636%

Totals Coverage Status
Change from base Build 9405508814: 0.0%
Covered Lines: 907
Relevant Lines: 1341

💛 - Coveralls

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jun 16, 2024
@Emojigit
Copy link
Contributor Author

This can be an opt-in feature if that would be better, but I am not sure exactly how to do that.

@BuckarooBanzay
Copy link
Member

And yeah, I used 10 commits before eventually passing the finish line.

no worries 😆

looks good, thanks 👍

@BuckarooBanzay BuckarooBanzay merged commit 89ea214 into minetest-mapserver:master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants