Convert IRC colour codes to minetest colour codes. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowNinja
reviewed
May 6, 2017
| if chunk == nil then | ||
| error(errorval) | ||
| end | ||
| chunk(ie) |
There was a problem hiding this comment.
This can be simplified to assert(loadfile(modpath.."/hooks.lua"))(ie).
There was a problem hiding this comment.
This should be split from this commit, IMHO. It's unrelated to the feature being added.
kaeza
requested changes
May 11, 2017
| local function convert_colour(text) | ||
| local lines = text:split("\3", true) | ||
| for index, line in pairs(lines) do | ||
| local irc_code = line:match("^(%d+)") |
There was a problem hiding this comment.
This block would take e.g. "01foo" at the start of the string as an escape sequence.
| @@ -9,14 +9,47 @@ local b64e = ie.require("mime").b64 | |||
| irc.hooks = {} | |||
| irc.registered_hooks = {} | |||
|
|
|||
| local colour_codes = { | |||
| [0] = "white", | |||
| [1] = "black", | |||
There was a problem hiding this comment.
You only really need the index for [0]. The others are auto-numbered starting at 1.
| [99] = "#ffffff" | ||
| } | ||
|
|
||
| local function convert_colour(text) |
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.