Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node detector blacklist api #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented May 18, 2024

Useful for mods which register "airlike" nodes, e.g. wielded_light for invisible light nodes.

@SmallJoker
Copy link
Member

  1. The name is misleading. It only backlists nodes in case no node name is specified by the player. I'd expect blacklists to apply in all cases. I'd suggest to rename it to "airlike" or "empty" nodes.
  2. Might it make sense to generally ignore all nodes with def.drawtype == "airlike" and not def.drowning for simplicity? That would automatically cover wielded_light.

@Niklp09
Copy link
Member Author

Niklp09 commented May 24, 2024

It only backlists nodes in case no node name is specified by the player.

Do you think it's better to ignore (blacklisted) nodes when they're specified? I left this since it's maybe helpful for some players 🤔 .

Edit: (expecting automatic node blacklisting) mesecons_random:ghoststone_active is a canidate which players might want to detect.

Might it make sense to generally ignore all nodes with def.drawtype == "airlike" and not def.drowning for simplicity?

I'll add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants