Add --terminal-silent flag to minetest #14734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan4ibanez
force-pushed
the
terminal-silent
branch
2 times, most recently
from
d369461
to
46dc675
Compare
rubenwardy
added
@ Startup / Config / Util
Feature ✨
any examples of what to type? |
|
|
In case there's any other confusion as to what I mean by, you can directly type into the terminal (stdin), here is an image. |
Do a minor module update Document this I gave it sleeping medicine slow it down, use portable, be sassy Add terminal-silent ability to minetest Start the guttening make it clean wot I can't believe this actually works Time for more fun checkpoint Almost there Getting better horrors beyond human comprehension WE HAVE LIFTOFF BOIS WOOOOO I have absolutely no idea what I'm doing gut it top tier debug info Found my typo there ur hell literally duct tape this on fix tabs Now check for silent Now only silent import Silent Silent thing Integrate terminal-silent I worded this badly Remove this comment
jordan4ibanez
force-pushed
the
terminal-silent
branch
from
b147896
to
3c3ce4e
Compare
|
Here is a video of a use case for it: https://youtu.be/X2O0gKai1CI Here is the repo for the gui used in the video: https://github.com/jordan4ibanez/minetest_gui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
It allows you to hook in GUIs and also as a side effect you can type straight into the regular terminal.
Some way to directly talk to minetest through the command line.
It uses cin nonblocking with std::thread::sleep_for() (thanks Lars && ExeVirus) on another thread via the ILogOutput and Thread parent classes to get this pipe dream functioning.
I have no idea.
Still no idea.
Because you should be able to talk to your local server through the terminal when it's being handled by other apps.
To do
This PR is a Ready for Review.
How to test
First, make sure your minetest.conf has
Next, build with this pr, launch
minetestserverorminetest --serverwith the flag--terminal-silentand then type straight into the terminal.