Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new texture properties not being sent for minetest.add_particle #14760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grorp
Copy link
Member

@grorp grorp commented Jun 18, 2024

This is the pure bugfix part of #14353 by @appgurueu.

To do

This PR is a Ready for Review.

How to test

minetest.register_on_joinplayer(function(player)
	minetest.after(1, function()
		local yawrot = vector.new(0, vector.dir_to_rotation(player:get_look_dir()).y, 0)
		minetest.add_particle({
			pos = player:get_pos() + vector.new(0, 1, 5):rotate(yawrot),
			velocity = vector.new(3, 0, 0):rotate(yawrot),
			expirationtime = 5,
			drag = vector.new(3, 3, 3),
			size = 20,
			animation = {
				type = "vertical_frames",
				aspect_w = 16,
				aspect_h = 16,
				length = 1
			},
			texture = { name = "fire_basic_flame_animated.png", scale = 0.5, alpha_tween = {1, 0}},
		})
	end)
end)

Expected results

5.8.0 server + 5.8.0 client: flame animated, but it's too big and doesn't fade out
5.8.0 server + PR client: flame animated, but it's too big and doesn't fade out

PR server + 5.8.0 client: flame animated, but it's too big and doesn't fade out
PR server + PR client: flame animated, smaller, fades out

doc/lua_api.md Show resolved Hide resolved
@grorp
Copy link
Member Author

grorp commented Jun 18, 2024

Fun fact: This bug was actually pointed out during review, but it was dismissed. https://github.com/minetest/minetest/pull/11545/files#r879759624

@grorp grorp requested a review from appgurueu June 18, 2024 21:23
@Zughy Zughy added this to the 5.9.0 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants