Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic LAN Discovery Implementation #14770

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

DustyBagel
Copy link

@DustyBagel DustyBagel commented Jun 21, 2024

This pr implements proller's lan implementation, which is adapted for minetest so that local servers can be discovered by clients on the same network in the server list.

This is for the feature request #10208

To do

This PR is a Work in Progress

  • Fix crash when exiting non dedicated local game.
  • Fix crash when minetest is shutting down.
  • Clean up/remove unnecessary code.

How to test

Currently not ready to test.

@DustyBagel

This comment was marked as resolved.

@rubenwardy rubenwardy changed the title Basic Lan Implementation Basic LAN Discovery Implementation Jun 21, 2024
@rubenwardy rubenwardy marked this pull request as draft June 21, 2024 22:04
@rubenwardy rubenwardy added the WIP The PR is still being worked on by its author and not ready yet. label Jun 21, 2024
@sfan5
Copy link
Member

sfan5 commented Jun 21, 2024

I don't want to discourage you but it's important to note that importing more than 900 lines of Freeminer-specific support code that (mostly) duplicates things that already exist inside MT is absolutely out of question.
This feature will need someone familiar with C++ clean it up or better yet rewrite it entirely.

@wsor4035 wsor4035 added the Feature ✨ PRs that add or enhance a feature label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature WIP The PR is still being worked on by its author and not ready yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants