Skip to content

Remove pre-commit from direct dependencies #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove pre-commit from direct dependencies #1127

wants to merge 2 commits into from

Conversation

g-as
Copy link

@g-as g-as commented Mar 14, 2025 •
edited
Loading

An argument can be made to have pre-commit in dev dependencies, but to me, pre-commit doesn't belong there either.

It is its own package manager and IMO shouldn't be in the same env as the project dependencies (main or dev).

@g-as g-as mentioned this pull request Mar 14, 2025
Merged
@gabriel-tessier gabriel-tessier added the help wanted Extra attention is needed label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-as @gabriel-tessier