Skip to content

Commit

Permalink
fix(client): Return nil and error if endpoint is empty string
Browse files Browse the repository at this point in the history
Why:
Passing an empty string as an endpoint to Client when instantiating a
new client might seem like something that should never happen but I
managed to trigger it while parsing some input files to register feeds
in bulk.

What:
In the execute() function, check early if the endpoint is "" and then
return immediately nil and a new error, named ErrEmptyEndpoint with a
descriptive string
  • Loading branch information
akosiaris committed Aug 18, 2024
1 parent e98e16e commit 7714a4e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions client/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ var (
ErrServerError = errors.New("miniflux: internal server error")
ErrNotFound = errors.New("miniflux: resource not found")
ErrBadRequest = errors.New("miniflux: bad request")
ErrEmptyEndpoint = errors.New("miniflux: empty endpoint provided")
)

type errorResponse struct {
Expand Down Expand Up @@ -62,6 +63,9 @@ func (r *request) Delete(path string) error {
}

func (r *request) execute(method, path string, data interface{}) (io.ReadCloser, error) {
if r.endpoint == "" {
return nil, ErrEmptyEndpoint
}
if r.endpoint[len(r.endpoint)-1:] == "/" {
r.endpoint = r.endpoint[:len(r.endpoint)-1]
}
Expand Down

0 comments on commit 7714a4e

Please sign in to comment.