feat: Allow customizing the display name of the OpenID Connect provider #2794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal users probably don't know what "OpenID Connect" means and they probably shouldn't need to. They know the name of the account provider, so allow the miniflux admin to specify that and show it to the user instead of the string "OpenID Connect". By default, the name is "OpenID Connect" which means this doesn't change the default behavior (except with German locale, discussed below).
I tested this by deploying it to my own instance, where it seems to work as expected.
Outstanding issues that I haven't figured out the best way to address:
hi_IN
locale doesn't use the string "OpenID Connect" or anything that looks like it. Not sure what the best way to approach this is, open to suggestions.de_DE
locale referred to it asOpenID-Connect
, this change will drop the-
from the default resulting in the string being set toOpenID Connect
. This feels easy enough to special case the default for if it's a problem.Do you follow the guidelines?