feat: add MetricsBuckets type and BucketAPIMetrics for per-bucket monitoring#590
Open
0xMALVEE wants to merge 1 commit intominio:mainfrom
Open
feat: add MetricsBuckets type and BucketAPIMetrics for per-bucket monitoring#5900xMALVEE wants to merge 1 commit intominio:mainfrom
0xMALVEE wants to merge 1 commit intominio:mainfrom
Conversation
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
from
e14c90d to
a90be41
Compare
klauspost
reviewed
May 7, 2026
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
3 times, most recently
from
ed5e7b3 to
442ad33
Compare
klauspost
requested changes
May 8, 2026
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
2 times, most recently
from
5042247 to
698cb50
Compare
klauspost
reviewed
May 8, 2026
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
from
698cb50 to
139bb96
Compare
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
from
139bb96 to
9ab2917
Compare
Contributor
Author
|
@klauspost take a look |
klauspost
approved these changes
May 8, 2026
Contributor
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
lgtm! Gives valuable data for multiple use cases and should still be reasonably sized - as well as give good caller flexibility.
Add BucketMetrics, BucketWindowMetrics, and BucketAPIMetrics types for tracking per-bucket S3 request counts, byte I/O, and time-series history across minute/hour/day windows. - BucketMetrics holds per-operation totals, byte counters (BytesIn, BytesOut), and time-series for one bucket in one time window - BucketWindowMetrics aggregates BucketMetrics across nodes with an N counter and metadata (interval, first-time); Merge right-aligns time-series slices so the most-recent slot always lines up - BucketAPIMetrics carries three independent windows (LastMinute, LastHour, LastDay) populated based on requested MetricFlags - Add Buckets []string to MetricsOptions for per-bucket filtering, encoded as a comma-separated ?buckets= query parameter - Regenerate metrics_gen.go
0xMALVEE
force-pushed
the
feat/bucket-metrics
branch
from
9ab2917 to
174bda1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add MetricsBuckets type and BucketAPIMetrics for per-bucket monitoring
required for pr: https://github.com/miniohq/eos/pull/4877