Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor messages by subclasses #1621

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 53 additions & 55 deletions adminapi/src/main/java/io/minio/admin/MinioAdminClient.java

Large diffs are not rendered by default.

64 changes: 64 additions & 0 deletions api/src/main/java/io/minio/AbortMultipartUploadArgs.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* MinIO Java SDK for Amazon S3 Compatible Cloud Storage, (C) 2025 MinIO, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.minio;

import java.util.Objects;

/**
* Argument class of {@link MinioAsyncClient#abortMultipartUpload} and {@link
* MinioClient#abortMultipartUpload}.
*/
public class AbortMultipartUploadArgs extends ObjectArgs {
private String uploadId;

public String uploadId() {
return uploadId;
}

public static Builder builder() {
return new Builder();
}

/** Argument builder of {@link AbortMultipartUploadArgs}. */
public static final class Builder extends ObjectArgs.Builder<Builder, AbortMultipartUploadArgs> {
@Override
protected void validate(AbortMultipartUploadArgs args) {
super.validate(args);
Utils.validateNotEmptyString(args.uploadId, "upload ID");
}

public Builder uploadId(String uploadId) {
Utils.validateNotEmptyString(uploadId, "upload ID");
operations.add(args -> args.uploadId = uploadId);
return this;
}
}

@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof AbortMultipartUploadArgs)) return false;
if (!super.equals(o)) return false;
AbortMultipartUploadArgs that = (AbortMultipartUploadArgs) o;
return Objects.equals(uploadId, that.uploadId);
}

@Override
public int hashCode() {
return Objects.hash(super.hashCode(), uploadId);
}
}
49 changes: 4 additions & 45 deletions api/src/main/java/io/minio/BaseArgs.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,75 +60,34 @@ public abstract static class Builder<B extends Builder<B, A>, A extends BaseArgs

protected abstract void validate(A args);

protected void validateNotNull(Object arg, String argName) {
if (arg == null) {
throw new IllegalArgumentException(argName + " must not be null.");
}
}

protected void validateNotEmptyString(String arg, String argName) {
validateNotNull(arg, argName);
if (arg.isEmpty()) {
throw new IllegalArgumentException(argName + " must be a non-empty string.");
}
}

protected void validateNullOrNotEmptyString(String arg, String argName) {
if (arg != null && arg.isEmpty()) {
throw new IllegalArgumentException(argName + " must be a non-empty string.");
}
}

protected void validateNullOrPositive(Number arg, String argName) {
if (arg != null && arg.longValue() < 0) {
throw new IllegalArgumentException(argName + " cannot be non-negative.");
}
}

public Builder() {
this.operations = new ArrayList<>();
}

protected Multimap<String, String> copyMultimap(Multimap<String, String> multimap) {
Multimap<String, String> multimapCopy = HashMultimap.create();
if (multimap != null) {
multimapCopy.putAll(multimap);
}
return Multimaps.unmodifiableMultimap(multimapCopy);
}

protected Multimap<String, String> toMultimap(Map<String, String> map) {
Multimap<String, String> multimap = HashMultimap.create();
if (map != null) {
multimap.putAll(Multimaps.forMap(map));
}
return Multimaps.unmodifiableMultimap(multimap);
}

@SuppressWarnings("unchecked") // Its safe to type cast to B as B extends this class.
public B extraHeaders(Multimap<String, String> headers) {
final Multimap<String, String> extraHeaders = copyMultimap(headers);
final Multimap<String, String> extraHeaders = Utils.newMultimap(headers);
operations.add(args -> args.extraHeaders = extraHeaders);
return (B) this;
}

@SuppressWarnings("unchecked") // Its safe to type cast to B as B extends this class.
public B extraQueryParams(Multimap<String, String> queryParams) {
final Multimap<String, String> extraQueryParams = copyMultimap(queryParams);
final Multimap<String, String> extraQueryParams = Utils.newMultimap(queryParams);
operations.add(args -> args.extraQueryParams = extraQueryParams);
return (B) this;
}

@SuppressWarnings("unchecked") // Its safe to type cast to B as B extends this class.
public B extraHeaders(Map<String, String> headers) {
final Multimap<String, String> extraHeaders = toMultimap(headers);
final Multimap<String, String> extraHeaders = Utils.newMultimap(headers);
operations.add(args -> args.extraHeaders = extraHeaders);
return (B) this;
}

@SuppressWarnings("unchecked") // Its safe to type cast to B as B extends this class.
public B extraQueryParams(Map<String, String> queryParams) {
final Multimap<String, String> extraQueryParams = toMultimap(queryParams);
final Multimap<String, String> extraQueryParams = Utils.newMultimap(queryParams);
operations.add(args -> args.extraQueryParams = extraQueryParams);
return (B) this;
}
Expand Down
Loading
Loading