-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFP-527]- Paginate provider index page #4736
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
From a technical point of view I'm happy to approve this but it is changing the view for case workers. In particular, to find a particular provider in the list it may be necessary to move forward multiple pages, especially as the 'find provider by email' does not actually find providers but users. It would be useful to get some user input before putting this live. |
^^ 👍 I agree, or sign off from product |
62066df
to
4e53005
Compare
4e53005
to
86b1eda
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
86b1eda
to
07a5b29
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did we ever get confirmation from the business that they are happy with the change? I think we should wait until that is confirmed before releasing.
What
The provider index page is very slow to load.
Ticket
CFP-527-Spike- Paginate provider index page
Why
Due to the large number of providers.
How
By paginating the list the load time can be improved greatly.
TODO (wip)