Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFP-527]- Paginate provider index page #4736

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NenehB
Copy link
Contributor

@NenehB NenehB commented Mar 14, 2022

What

The provider index page is very slow to load.

Ticket

CFP-527-Spike- Paginate provider index page

Why

Due to the large number of providers.

How

By paginating the list the load time can be improved greatly.


TODO (wip)

  • paginate provider page
  • paginate caseworkers page

Copy link
Contributor

@naseberry naseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrmhaig
Copy link
Contributor

jrmhaig commented Mar 15, 2022

From a technical point of view I'm happy to approve this but it is changing the view for case workers. In particular, to find a particular provider in the list it may be necessary to move forward multiple pages, especially as the 'find provider by email' does not actually find providers but users. It would be useful to get some user input before putting this live.

@jsugarman
Copy link
Contributor

From a technical point of view I'm happy to approve this but it is changing the view for case workers. In particular, to find a particular provider in the list it may be necessary to move forward multiple pages, especially as the 'find provider by email' does not actually find providers but users. It would be useful to get some user input before putting this live.

^^ 👍 I agree, or sign off from product

@NenehB NenehB force-pushed the cfp-507-paginate-provider-index-page branch from 62066df to 4e53005 Compare March 18, 2022 10:28
@NenehB NenehB marked this pull request as ready for review April 14, 2022 09:14
@NenehB NenehB force-pushed the cfp-507-paginate-provider-index-page branch from 4e53005 to 86b1eda Compare October 11, 2022 09:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NenehB NenehB changed the title [CFP-527]- Spike- Paginate provider index page [CFP-527]- Paginate provider index page Dec 14, 2022
@NenehB NenehB force-pushed the cfp-507-paginate-provider-index-page branch from 86b1eda to 07a5b29 Compare December 14, 2022 15:05
@NenehB NenehB requested review from a team as code owners December 14, 2022 15:05
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@mpw5 mpw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did we ever get confirmation from the business that they are happy with the change? I think we should wait until that is confirmed before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants