Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch- decouple svg.js from app.js and have it as a separate file #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkdrk
Copy link

@dkdrk dkdrk commented Oct 10, 2017

No description provided.

@rlivsey
Copy link
Member

rlivsey commented Oct 10, 2017

👍 I like the direction this is going.

Would be great if it didn't use the Ember global, this is going away in future ember releases and don't think we should hang data off it.

Maybe should just be a global constant like APP_SVGS, or wrap it in define so that it can be imported into the app vs a global?

Eg similar pattern to shims like:

(function() {
  function svgModule() {
    'use strict';
    const SVGS = {} // the SVG data
    return { 'default': SVGS };
  }
  define('svgs', [], svgModule);
})();

@buschtoens
Copy link
Collaborator

Referencing buschtoens/broccoli-flatiron#1

@dkdrk
Copy link
Author

dkdrk commented Nov 23, 2017

any other changes to be done @rlivsey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants