Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port internetnl bit → nibble #4026

Merged
merged 23 commits into from
Jan 29, 2025

Conversation

originalsouth
Copy link
Contributor

Changes

Port internetnl bit → nibble

Issue link

#3808

Demo

N/A

QA notes

N/A


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • [ x] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth
Copy link
Contributor Author

Blocked on #4000 resolution.

@originalsouth originalsouth added the nibbles Everything nibble related label Jan 15, 2025
@originalsouth originalsouth marked this pull request as ready for review January 29, 2025 09:21
@originalsouth originalsouth requested a review from a team as a code owner January 29, 2025 09:21
@originalsouth originalsouth self-assigned this Jan 29, 2025
@originalsouth originalsouth merged commit ee65372 into feature/nibbles Jan 29, 2025
26 checks passed
@originalsouth originalsouth deleted the feature/nibbles-internetnl branch January 29, 2025 13:50
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.3% Coverage on New Code (required ≥ 80%)
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nibbles Everything nibble related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants