Fix config.py prompt recursion #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python config script `interactive_prompt_input` functions recursed on error, requiring a balanced number of `0` entries to exit cleanly. This is unnecessary, since the prompt body itself already loops and can just fall through to the next iteration to reprompt after an error. Remove the recursive call so entering zero to finish scheme selection exits promptly.
Some code editors flag this, or automatically correct it. Addressing this in a single commit reduces confusion for readers and noise in making other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python config script function
interactive_prompt_inputrecursed on error, requiring a balanced number of0entries to exit cleanly. This is unnecessary, since the prompt body itself already loops and can just fall through to the next iteration to re-prompt after an error.This removes the recursive call so entering zero to finish scheme selection exits promptly.
Also removes trailing whitespace from python source files.