Cleanup #1
Open
Cleanup #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the classes to proper packages. - Includes changes to files after applying auto-formatting for consistency throughtout the project files. - Updated .gitignore to incluide .idea folder which is not required to be shared and is auto-generated. - Updated the splash view to show properly when in landscape mode.
- Took out POJO classes from activity and made into own separate class. - Refactored the changable URLS and buckets etc to their own Settings class. - Moved some constants out of the Java files. - Made a BaseActivity which will have all common stuff to use used by all other activities. - Made a SharedPreferenceUtil that will contain all SharedPreference related code. - Removed old not needed commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of pending cleanup including