Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
googlecsi
for Compute Engine persistent disk CSI Driverfailure-domain.beta.kubernetes.io/*
to define the disk zone/region in the newgooglecsi
backendCompute Engine persistent disk CSI Driver
This seems to be the newer driver for PV in GKE, they use a slightly different yaml structure, so I created a new backend called
googlecsi
that supports this driverUse csi path instead of deprecated
failure-domain.beta.kubernetes.io/*
for defining the zone or regionCompared to the
google
backend we don't need to rely on the deprecated annotationsfailure-domain.beta.kubernetes.io/region
andfailure-domain.beta.kubernetes.io/zone
to retrieve the region and zone, as the PV directly gives that information:You can already test it using that docker image https://hub.docker.com/repository/docker/igoooor/k8s-snapshots