Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock on building bundles with the same output target #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpeedProg
Copy link

I ran into problems with the autobuild starting the build progress so often that the server ran out of memory (from all the node instances).
So here is my solution to preventing this from happening

@miracle2k
Copy link
Owner

Thanks for the PR. I think a locking system is a sensible improvement for this case, but I think this is incomplete as-is. It would only work when using a threaded model, but not if the workers are forked. To handle multiple processes competing, the lock has to be filesystem based, really; a threading lock is not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants