Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dynamic YouTube Music params #722

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

miraclx
Copy link
Owner

@miraclx miraclx commented Nov 18, 2024

Fixes #720, #717.

YTM's client version got bumped up from 0.1 to 1.20241111.01.00.

This changes the code to make it dynamic, like we previously did with the API key.

Copy link

github-actions bot commented Nov 18, 2024


🐋 🤖

A docker image for this PR has been built!

docker pull freyrcli/freyrjs-git:pr-722
Base (master)
This Patch


What's this?

This docker image is a self-contained sandbox that includes all the patches made in this PR. Allowing others to easily use your patches without waiting for it to get merged and released officially.

For more context, see https://github.com/miraclx/freyr-js#docker-development.

@DylanMS
Copy link

DylanMS commented Dec 13, 2024

Hello I still expirience error of youtube. I cannot install docker on my Macbook AIR M3 it always say Cannot connect to the Docker daemon at unix:///Users/xxx/Library/Containers/com.docker.docker/Data/docker.raw.sock. Is the docker daemon running?
I have Newest version of freyr v0.10.3. how can i install patch without docker. I spend 3H of starting docker i hate it. i dont want to use docker.
Thanks for answering
And also thanks for your job. 🥰 I hope i can after NY 😉 send little donation.

@EthanPany
Copy link

Hello I still expirience error of youtube. I cannot install docker on my Macbook AIR M3 it always say Cannot connect to the Docker daemon at unix:///Users/xxx/Library/Containers/com.docker.docker/Data/docker.raw.sock. Is the docker daemon running? I have Newest version of freyr v0.10.3. how can i install patch without docker. I spend 3H of starting docker i hate it. i dont want to use docker. Thanks for answering And also thanks for your job. 🥰 I hope i can after NY 😉 send little donation.

Bro, I think your problem is with the installation of docker itself. Try starting the docker app manually before running the comments.

Anyway, this version does not work for me. I'm still getting the 404 error. May take a closer look later.

@miraclx
Copy link
Owner Author

miraclx commented Jan 6, 2025

I was hoping I'd come up with a patch to fix CI, but it looks like youtube is blanket-banning use of dataserver IPs without logging in.

And I'm not keen with the idea of logging in for CI tests 😪

So I'll merge as-is, which should fix master.

@miraclx miraclx merged commit 05c0591 into master Jan 6, 2025
9 of 21 checks passed
@miraclx miraclx deleted the miraclx/use-dynamic-ytm-params branch January 6, 2025 14:20
@miraclx
Copy link
Owner Author

miraclx commented Jan 6, 2025

@DylanMS, how did you install docker? if it's via docker desktop, just open the app. And it should work. If not, I suggest installing docker desktop or something like OrbStack.

If you had to use this patch without docker, here's how;

$ git clone https://github.com/miraclx/freyr-js

that should clone master (which this was just merged into) in to the freyr-js folder

$ cd freyr-js
$ npm install

at this point instead of the freyr <query> command, you can use node cli.js <query>

if you want to reuse the freyr command, and you still have the old version of freyr installed (and accessible with the freyr command), I'd suggest removing that one

$ npm link

now, the freyr command should point to your local clone

keeping it up to date should only be as simple as

$ git pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YouTube Music : Response code 404 (Not Found)
3 participants