Update irmin to the last version of ocaml-git

[dinosaure]

This is a draft about an update to the new version of git presented on mirage/ocaml-git#395 and the new version of conduit presented on mirage/ocaml-conduit#311 (including patches into mirage/ocaml-cohttp#692). I think the patch is small enough. The CI will fail but locally (with a pin of conduit and cohttp and a simple dune runtest) it's work (believe me).

This is a draft but people can start to comment it if some details are obscures. Currently, the biggest change is about the synchronization where I updated the interface which seems to be much more simpler.

[craigfe]

The CI will fail but locally (with a pin of conduit and cohttp and a simple dune runtest) it's work (believe me).

If you want to get the CI to work, you can add pin-depends on specific commits as we're doing here. (Needs to be a commit hash, otherwise OCaml-CI will not accept it.) Also fine to just leave this failing until the upstream changes have been released 🤷

[dinosaure]

• clean the PR
• CI is happy

[dinosaure]

Re-updated to the last version of ocaml-git and remove the update to conduit.3.0.0 (useless due to mirage/ocaml-git#428)

[dinosaure]

Ready to review 👍., ocaml-git is freezed.

[samoht]

Thanks for the patch. My main concern is that I would like to avoid mimic to leak in non-git related codebase. It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

[dinosaure]

It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

I'm not sure, even if mimic seems specialized to ocaml-git, I move some of my codebase (SMTP and HTTP/AF) with this small library.

[samoht]

The diff in irmin-http.opam are weird but I can live with that :-) why does irmin-http now depends on Git? I am not sure I am good with this change.

Could you also add a line in the changelog (and point to https://github.com/mirage/irmin/issues?q=is%3Aissue+is%3Aopen+git+label%3Agit which would probably be fixed 🎉) ? After that I think we are good to merge.

[dinosaure]

The diff in irmin-http.opam are weird but I can live with that :-) why does irmin-http now depends on Git? I am not sure I am good with this change.

I reverted the patch on irmin-http.opam however, dune-opam-lint still complains about missing dependencies even if I did not updated src/irmin-http/dune or the irmin-unix's codebase (according to the diff). So I don't really understand why such dependencies appears.

[dinosaure]

So my revert seems good. However, I don't think that this PR fixes #914 or #917 (but #1001 is fixed according to a test in ocaml-git). I will add an entry into the Changelog 👍.

[dinosaure]

According to the release of git.3.0.0 (see ocaml/opam-repository#17950), this PR is ready to merge.

[samoht]

Can you fix dune build @fmt to make the CI happy?

[dinosaure]

It's done 👍.

[craigfe]

LGTM, thanks!