Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a READ_ONLY interface which allows us to manipulate the block device outside lwt #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dinosaure
Copy link
Member

As discussed into our MirageOS meeting, I would like to add this new interface (and I will add a new type into mirage/mirage) to allow the manipulation of a block-device as a read-only filesystem. It fixes #53.

More precisely, this implementation is not a mmap implementation, it's just a referentially transparent read operation which can be outside lwt because we don't need to deal (with such view) with side-effects (like write).

@hannesm
Copy link
Member

hannesm commented Jan 9, 2023

This looks nice, but shouldn't we move all READ_ONLY operations to outside the lwt monad? And eventually drop the disconnect, or do you see any use thereof in a concrete implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to mmap outside the Lwt monad
2 participants