Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Extra Slashes #793

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Drop Extra Slashes #793

merged 1 commit into from
Feb 25, 2023

Conversation

cuihtlauac
Copy link
Contributor

Fix: #772
Previous PR: #788
Same changes as: ocaml/ocaml.org#866

Fix: #772
Previous PR: #788
Same changes as: ocaml/ocaml.org#866
@samoht
Copy link
Member

samoht commented Feb 23, 2023

What's the status of this now that #788 is merged?

@samoht samoht requested a review from TheLortex February 23, 2023 16:50
@cuihtlauac
Copy link
Contributor Author

cuihtlauac commented Feb 23, 2023

What's the status of this now that #788 is merged?

The same code was merged into ocaml.org (ocaml/ocaml.org#866) and ocaml-ci (ocurrent/ocaml-ci#760).

The initial issues (reported in #772 and ocaml/ocaml.org#166) as well as the issues mentioned by @reynir (in the discussions of #788) aren't observed in ocaml.org.

Copy link
Member

@TheLortex TheLortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix !

@hannesm hannesm merged commit 61381cb into mirage:master Feb 25, 2023
@hannesm
Copy link
Member

hannesm commented Feb 25, 2023

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mirage.io/community/ returns an blank 404 page
4 participants