Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI scripts #1039

Merged
merged 6 commits into from
Jun 27, 2024
Merged

chore: update CI scripts #1039

merged 6 commits into from
Jun 27, 2024

Conversation

MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Jun 19, 2024

This PR updates the GitHub Actions scripts for internal dependencies, updates cohttp test dependencies lower bounds, applies ocamlformat, then splits jobs between "default" (lwt and mirage), "async", "eio", and "bench" groups, to avoid conflicts. Finally, only 4.14 and 5.2 remain in testing with afl.

The CI doesn't pass yet because it's awaiting fixes for deprecation warnings from #1040, and the Ubuntu Snap Store seems currently down.

@MisterDA
Copy link
Contributor Author

I think this is ready for review. Sorry for the previous force-pushes.

"ounit" {with-test}
"alcotest" {with-test}
"ounit2" {with-test}
"alcotest" {with-test & >= "1.7.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more dependencies here:

cohttp-curl-async.opam: changes needed:
  "async_kernel" {with-test}               [from cohttp-curl-async/test] (missing {with-test} annotation)
  "async_unix" {with-test}                 [from cohttp-curl-async/test] (missing {with-test} annotation)
  "core_kernel" {with-test & >= "v0.16.0"} [from cohttp-curl-async/test]

@rgrinberg
Copy link
Member

Moved the ocamlformat commit into a separate PR #1044 to unblock the nix clean up.

Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Add its own build job.

Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
@rgrinberg rgrinberg merged commit dfd3327 into mirage:master Jun 27, 2024
7 of 14 checks passed
@MisterDA MisterDA deleted the ci branch July 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants