1.20.2 + 1.20.3 support #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for 1.20.2
mircokroon
force-pushed
the
1_20_2_support
branch
from
1e7df36 to
fcad537
Compare
mircokroon
force-pushed
the
1_20_2_support
branch
from
fcad537 to
4b4570f
Compare
zomabies
reviewed
Nov 28, 2023
| @@ -73,16 +70,71 @@ public void addEntity(DataTypeProvider provider, Function<DataTypeProvider, Enti | |||
| }); | |||
|
|
|||
| if (ent instanceof Villager villager) { | |||
| WorldManager.getInstance().getVillagerManager().loadPreviousTradeAt(villager); | |||
There was a problem hiding this comment.
This unfortunately breaks villager trades saving when the villager is reloaded.
There was a problem hiding this comment.
I guess this can be fixed later, I think most people aren't too concerned with villagers anyway. Maybe someone else has time to go over it and submit a PR for it.
Update for 1.20.3, fix registryData error for 1.20.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt at a PR because Git is hard (apparently)
Changes by @nnnlog