-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve extensions performance & add OpenTelemetry #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
changed the title
Extension performacne & OpenTelemetry
Improve extension performance & add OpenTelemetry
Jun 2, 2023
rafalp
changed the title
Improve extension performance & add OpenTelemetry
Improve extensions performance & add OpenTelemetry
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 98.24% 97.81% -0.44%
==========================================
Files 115 115
Lines 7511 7770 +259
==========================================
+ Hits 7379 7600 +221
- Misses 132 170 +38
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dacevedo12
reviewed
Jun 5, 2023
dacevedo12
reviewed
Jun 5, 2023
Thanks for your feedback, @dacevedo12, I've did some tweaks. |
rafalp
requested review from
dacevedo12 and
mat-sop
and removed request for
dacevedo12
June 5, 2023 17:01
mat-sop
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes separate
ExtensionSync
and synchronous extensions, making extensions work in both async and sync context based onnext_
being coroutine function or not.Fixes #649
TODO