Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add full typescript support #789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

moonrailgun
Copy link

This is a long term work, so i wanna create pr as early as possible, and i will finish it in the next period of time.

I am use emoji-mart v3 before in my work msgbyte/tailchat. and i wanna upgrade to v5(for latest support for this repo). v5 looks like have a builtin typescript support and write source code with ts language in surface, but not provide any real type definition. After lots month observe, its looks not plan to fill it.

And i am glad to contribute some code to finish it.

We can communicate in time in this pr.

@moonrailgun
Copy link
Author

Hi, @faisal212 . It looks like you approve a WIP pr.

I actually found that this part of the job was a lot bigger than I thought. I didn't have enough time to add all the types. The current work is only a small part of all the work.

If you expect me to merge existing work into it, I can resolve the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants