-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the emoji version 15.0 to emoji-mart/data
#844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following codes need to be changed:
emoji-mart/packages/emoji-mart/src/components/Picker/PickerProps.ts
Lines 21 to 22 in d29728f
value: 14, | |
choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14], |
- value: 14,
- choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14],
+ value: 15,
+ choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14, 15],
emoji-mart/packages/emoji-mart/src/helpers/native-support.ts
Lines 2 to 4 in d29728f
const VERSIONS = [ | |
{ v: 14, emoji: '🫠' }, | |
{ v: 13.1, emoji: '😶🌫️' }, |
const VERSIONS = [
+ { v: 15, emoji: '🫨' },
{ v: 14, emoji: '🫠' },
wish this PR be merged quickly 😄
Why didn't it merge? |
@vemonet @gomjellie can this be wrapped up and released? Seems like this project may have been abandoned? |
@kainosnoema a month ago I sent an email to Missive, the company responsible for this repo, to ask them about their plan for the future. I did not get an answer yet This repository is used by many projects, and it is in a pretty good shape, it would be a shame to let it go to waste. On my fork I have added some scripts to easily update emojis to newer versions, it should not be hard to maintain I don't have much time right now, but I am considering to create a maintained fork later this year if nothing has changed, let me know if you would be interested in helping! |
Sorry for the delay; thanks for submitting the PR @vemonet 🤘🏼 |
15 doesn't show as an option here yet, FYI https://missiveapp.com/open/emoji-mart |
Line 103 in 16978d0
|
Hi @EtienneLem I upgraded the dependencies in the
emoji-mart/data
package.json
, added version 15 to the list of emojis versions built, and run the build to add emoji version 15.0 to the packageIt adds a few new emojis like 🫎 🪿 🫏: https://emojipedia.org/emoji-15.0/
Thanks a lot