locale ko -> kr #898
Closed
locale ko -> kr #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oinochoe
reviewed
Feb 26, 2024
| @@ -75,7 +75,7 @@ | |||
| <option value="hi">हिन्दी</option> | |||
| <option value="it">Italiano</option> | |||
| <option value="ja">日本語</option> | |||
There was a problem hiding this comment.
@cyd5538 In that sense, I think “ja” should be changed to “jp”?
There was a problem hiding this comment.
So I think it makes sense to consider "ko" or all the rest of the languages also change.
There was a problem hiding this comment.
@oinochoe That's a good comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you read the official documentation and install it,
npm install --save emoji-mart @emoji-mart/data @emoji-mart/react
version "emoji-mart": "^5.5.2"
The Korean file is kr.json and the main.js locale choices is kr.
Because it is confusing, it would be better to consider kr.