Skip to content

Merge assets & JNI Native libraries from AAR #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Merge assets & JNI Native libraries from AAR #3555

wants to merge 8 commits into from

Conversation

jewelshkjony
Copy link
Contributor

@jewelshkjony jewelshkjony commented Aug 12, 2025 •
edited
Loading

General items:

For all other changes:

  • I branched from master
  • My pull request has master as the base

What does this PR accomplish?

This PR is a modified and updated version of this PR.

Changes # .

  • Retrieves and merges assets and JNI native (.so) libraries if available.
  • Avoid attaching duplicate libraries to avoid potential conflicts.

Fixes # .

@AppInventorWorkerBee
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@AppInventorWorkerBee
Copy link
Collaborator

Can one of the admins verify this patch?

@jewelshkjony
Copy link
Contributor Author

@AppInventorWorkerBee OK to test

@bigraymasoom
Copy link

@AppInventorWorkerBee OK to test

@jewelshkjony jewelshkjony marked this pull request as draft August 14, 2025 10:38
@jewelshkjony jewelshkjony marked this pull request as ready for review August 14, 2025 13:48
@jewelshkjony
Copy link
Contributor Author

@ewpatton could you please review this PR?

@SusanRatiLane
Copy link
Contributor

@AppInventorWorkerBee ok to test

MahmoudHooda2019

This comment was marked as duplicate.

Sign in to view

buxipro
buxipro approved these changes Aug 14, 2025
View reviewed changes
Copy link

@buxipro buxipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @jewelshkjony! I hope we can have this in the upcoming update. It’ll be a big benefit for us extension devs.

MahmoudHooda2019
MahmoudHooda2019 approved these changes Aug 14, 2025
View reviewed changes
Copy link

@MahmoudHooda2019 MahmoudHooda2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jewelshkjony , I hope it will be added in the next update. This will be very useful for us as extension developers.

@jewelshkjony jewelshkjony mentioned this pull request Aug 15, 2025
Merged
@jewelshkjony jewelshkjony changed the title Attach AAR libraries with assets & JNI Native libraries for extensions Merge assets & JNI Native libraries from AAR Aug 15, 2025
@jewelshkjony jewelshkjony changed the title Merge assets & JNI Native libraries from AAR Merge assets & JNI Native libraries from AAR Aug 15, 2025
@jewelshkjony
Copy link
Contributor Author

The @UsesAssets annotation includes an extension's assets under the extension's package name. However, assets included in the AAR file should be placed in the application's root assets directory. This PR resolves this issue by merging assets from the AAR into the application's root directory. As AI2 is considering providing AAR support for extensions, @SusanRatiLane your review of the PR would be greatly appreciated.

md0686888
md0686888 approved these changes Aug 16, 2025
View reviewed changes
Copy link

@md0686888 md0686888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses the requirements of an AAR, and I’m hopeful that AI2 will approve and merge it very soon.

rss2nse
rss2nse approved these changes Aug 16, 2025
View reviewed changes
Copy link

@rss2nse rss2nse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. It is a welcome change. Welcome @jewelshkjony , your hardwork is awesome to bring aar lib support in mit

vsnshanmuganathan
vsnshanmuganathan approved these changes Aug 16, 2025
View reviewed changes
Copy link

@vsnshanmuganathan vsnshanmuganathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a significant improvement, as it merges assets and native libraries in a seamless way. This integration will undoubtedly be a game-changer for extension developers, simplifying workflows and enhancing functionality. Great work on pushing this forward!

@jewelshkjony
Use Document APIs to read packageName
5645a8a 
- org.w3c.dom & javax.xml.parsers APIs for better code readability.
hadiich528
hadiich528 approved these changes Aug 18, 2025
View reviewed changes
Copy link

@hadiich528 hadiich528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes automatically merge assets and native libraries from AAR, I believe it will definitely be a lifesaver for us (extension developers).

TheKStudio25
TheKStudio25 approved these changes Aug 18, 2025
View reviewed changes
Copy link

@TheKStudio25 TheKStudio25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Jewel. This is very useful. Thanks.

@GXDEVS
Copy link

GXDEVS commented Aug 18, 2025

@AppInventorWorkerBee Ok to test 😀

GXDEVS
GXDEVS approved these changes Aug 18, 2025
View reviewed changes
Copy link

@GXDEVS GXDEVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jisqyv jisqyv added the on ai2-test Code is deployed on ai2-test.appinventor.mit.edu label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
9 more reviewers

@bigraymasoom bigraymasoom bigraymasoom approved these changes

@MahmoudHooda2019 MahmoudHooda2019 MahmoudHooda2019 approved these changes

@rss2nse rss2nse rss2nse approved these changes

@buxipro buxipro buxipro approved these changes

@GXDEVS GXDEVS GXDEVS approved these changes

@md0686888 md0686888 md0686888 approved these changes

@vsnshanmuganathan vsnshanmuganathan vsnshanmuganathan approved these changes

@TheKStudio25 TheKStudio25 TheKStudio25 approved these changes

@hadiich528 hadiich528 hadiich528 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
for-ai2-test on ai2-test Code is deployed on ai2-test.appinventor.mit.edu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.