create secondary view for Neo landing screen AND setValueFormat #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 8, 2025 13:34
cindyloo
force-pushed
the
clean-pr-branch-v3
branch
from
76bdbea to
196e1c1
Compare
…then despite my attempts to stop the keyboard from moving things around, it moves things around
Change-Id: I79b4893dff849ea233a0c241abcc9d3a8d019ed3
7 tasks
cindyloo
changed the title
ewpatton
reviewed
Sep 24, 2025
Comment on lines
-155
to
-165
| interpreter.evalForm("(add-component Screen1 AIComponentKit.BarcodeScanner BarcodeScanner1)") | ||
| interpreter.evalForm("(define-event BarcodeScanner1 AfterScan(result) (yail:invoke AICompanionApp.ViewController 'gotText result))") | ||
| if let exception = interpreter.exception { | ||
| NSLog("Exception: \(exception.name) (\(exception))") | ||
| } | ||
| interpreter.evalForm("(add-component Screen1 AIComponentKit.PhoneStatus PhoneStatus1)") | ||
| interpreter.evalForm("(add-component Screen1 AIComponentKit.Notifier Notifier1)") | ||
| interpreter.evalForm(""" | ||
| (define-event Notifier1 AfterChoosing($choice)(set-this-form) | ||
| (if (call-yail-primitive yail-equal? (*list-for-runtime* (lexical-value $choice) "Exit") '(any any) "=") (begin (call-component-method 'PhoneStatus1 'shutdown (*list-for-runtime*) '())))) | ||
| """) |
There was a problem hiding this comment.
Note that this code is important as it sets up the PhoneStatus and Notifier components, referenced on lines 166-167 below and on lines 214-215 in the new version. If you put the phone in airplane mode and try running this version, it results in a crash when trying to display the warning about the lack of Wifi. At a minimum, you'll want to migrate these lines.
There was a problem hiding this comment.
that code was moved to setupCurrentForm(). and should still be operating with the same precedence? will look into. perhaps it is because form.makeTopForm() is called twice
cindyloo
commented
Sep 24, 2025
|
|
||
| let interpreter = initializeInterpreter() | ||
|
|
||
| form.makeTopForm() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # 3374 and extends PR #3581
under Main.storyboard we now have
ReplForm
-View
--neoView
--legacyView
we have the "?" on the landing (QR) screen that should take you to the onboarding screens
we have the My Saved Apps button
todo- key monitoring that @ewpatton suggested to handle the onboarding/menu toggle of the right bar button