-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(no-ref): Add Docker build workflow and Dockerfile #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TarunShekhar
wants to merge
25
commits into
mit-cml:master
Choose a base branch
from
ekalavya-io:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+236
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a GitHub Actions workflow for building and pushing Docker images, adds a Dockerfile for runtime configuration, and replaces the codi-logo.svg and codi-logo-dark.svg files with new versions.
Introduces a GitHub Actions workflow for building and pushing a Docker image for the App Inventor project, triggered manually on the develop branch. Adds a Dockerfile to create a runtime image with the built artifacts and App Engine SDK, enabling local server execution.
Collaborator
|
Can one of the admins verify this patch? |
1 similar comment
Collaborator
|
Can one of the admins verify this patch? |
Changed the workflow trigger condition to run when the ref is 'refs/heads/develop' instead of the previous feature branch.
Changed the Dockerfile to copy and reference the war directory from appinventor/appengine/build/war instead of appinventor/build/war, ensuring the correct build artifacts are used for the local server.
Feature/no ref/ekalavya
Changed the server WAR path from /appinventor/build/war to /appinventor/appengine/build/war and replaced --address with --host in the CMD instruction to align with updated server configuration.
Switches the container entrypoint from directly invoking the Java DevAppServerMain class to using the dev_appserver.sh script. This improves compatibility and aligns with standard App Engine development server usage.
Refactor Dockerfile to use multi-stage builds for better separation of build and runtime environments. Added extraction of Google Cloud SDK in the builder stage.
Replaced copying of Google Cloud SDK directories with symbolic links for app engine and java dev app server.
Refactors the Dockerfile to use a multi-stage build for installing the Google Cloud SDK, reducing image size and improving build efficiency. Only necessary components for App Engine Java are included, and unused parts of the SDK are stripped out. Updates the PATH and ensures required Python binaries are available in the final image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a GitHub Actions workflow for building and pushing a Docker image for the App Inventor project, triggered manually on the develop branch. Adds a Dockerfile to create a runtime image with the built artifacts and App Engine SDK, enabling local server execution.
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
Fixes # .
Resolves # .