Skip to content

Change TEXTING_REQUEST_CODE to fit 16-bit limit #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barreeeiroo wants to merge 1 commit into
base: ucr
Choose a base branch
from
+5 −2
Open

Change TEXTING_REQUEST_CODE to fit 16-bit limit #3668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions appinventor/components/src/com/google/appinventor/components/runtime/Texting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,12 @@ public class Texting extends AndroidNonvisibleComponent
public static final String TAG = "Texting Component";

/**
* Magic number "TEXT" used to report when a text message has been sent.
* Magic number "TX" used to report when a text message has been sent.
* Changed from 0x54455854 ("TEXT") to 0x5458 ("TX") to fit within Android's
* 16-bit request code limit (0-65535). The original value caused
* "can only use lower 16 bits for request code" runtime error.
*/
public static final int TEXTING_REQUEST_CODE = 0x54455854;
public static final int TEXTING_REQUEST_CODE = 0x5458;

public static final String SMS_RECEIVED = "android.provider.Telephony.SMS_RECEIVED";
public static final String GV_SMS_RECEIVED = "com.google.android.apps.googlevoice.SMS_RECEIVED";
Expand Down