Skip to content

Fix CSV parsing error by stripping UTF-8 BOM before parsing #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshrajsinh-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CSV parsing error by stripping UTF-8 BOM before parsing #3682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions appinventor/components/src/com/google/appinventor/components/runtime/util/CsvUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,23 @@ public final class CsvUtil {
private CsvUtil() {
}

// ! old code
// public static YailList fromCsvTable(String csvString) throws Exception {
// CsvParser csvParser = new CsvParser(new StringReader(csvString));
// ArrayList<YailList> csvList = new ArrayList<YailList>();
// while (csvParser.hasNext()) {
// csvList.add(YailList.makeList(csvParser.next()));
// }
// csvParser.throwAnyProblem();
// return YailList.makeList(csvList);
// }

public static YailList fromCsvTable(String csvString) throws Exception {
// FIX: strip UTF-8 BOM if present
if (csvString != null && csvString.startsWith("\uFEFF")) {
csvString = csvString.substring(1);
}

CsvParser csvParser = new CsvParser(new StringReader(csvString));
ArrayList<YailList> csvList = new ArrayList<YailList>();
while (csvParser.hasNext()) {
Expand All @@ -36,6 +52,7 @@ public static YailList fromCsvTable(String csvString) throws Exception {
return YailList.makeList(csvList);
}


public static YailList fromCsvRow(String csvString) throws Exception {
CsvParser csvParser = new CsvParser(new StringReader(csvString));
if (csvParser.hasNext()) {
Expand Down