Preserve multiselection when shift held on right click #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HollowMan6 this one scares me a little because it's such a nest of if/else conditions ha, but I tried to be as surgical as possible. |
HollowMan6
approved these changes
Sep 13, 2025
Collaborator
HollowMan6
left a comment
HollowMan6
left a comment
There was a problem hiding this comment.
LGTM when I test this one, but anyway, we can merge this now and fix it later if anything pops up.
mjgallag
deleted the
preserve-multiselection-when-shift-held-on-right-click
branch
Contributor
Author
|
@HollowMan6 thanks, it should get a fair bit of testing once I get it into mit-cml/appinventor-sources#3588. @mark-friedman would appreciate a patch release when you get a chance, thanks! |
Collaborator
|
@mjgallag Just bumped the version and made a release on the GitHub side https://github.com/mit-cml/workspace-multiselect/releases/tag/v1.0.2. @mark-friedman, would still need your help to release it on the NPM side since I don't have access to that. |
Collaborator
|
@HollowMan6 Published to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #112