Updates to Config file Auto-generation (includes #138) #209
Conversation
|
@maurermi note the merge conflict in |
|
Merge resolved, updates required to unit tests to reflect new functionality as well (coming soon) |
maurermi
force-pushed
the
config_generation
branch
13 times, most recently
from
f6d52cf
to
44ab494
Compare
maurermi
force-pushed
the
config_generation
branch
4 times, most recently
from
65afd30
to
896e23a
Compare
| = get_param_from_template_file(watchtower_count_key, | ||
| config_map); | ||
| return_msg += create_component(shard_count_key, | ||
| std::get<size_t>(shard_count), |
There was a problem hiding this comment.
If shard_count is not specified in the template file, or is initialized to anything besides a legal size_t value, std::get<size_t>(shard_count) will fail and cause an abort. This also applies to all below calls of create_component with their corresponding component names.
Since this is a tool external to the system, this is probably not a big deal, but I am putting this here for consideration.
There was a problem hiding this comment.
Yeah, I'm also not too concerned about this. Though, anything that's a bit error-prone like this underscores that everything here would be less error-prone if we had better error-handling for config file parsing.
|
@HalosGhost this is ready for a review -- in particular it would be good to know whether (and if so, what) additional functionality would be helpful to be included. |
| = get_param_from_template_file(watchtower_count_key, | ||
| config_map); | ||
| return_msg += create_component(shard_count_key, | ||
| std::get<size_t>(shard_count), |
There was a problem hiding this comment.
Yeah, I'm also not too concerned about this. Though, anything that's a bit error-prone like this underscores that everything here would be less error-prone if we had better error-handling for config file parsing.
maurermi
force-pushed
the
config_generation
branch
from
896e23a
to
5dc9b1a
Compare
Removes identification of build directory, as sending file to build directory has been replaced by priting config file to stdout. Also adds support for seeding by generating a seed key if necessary. Update to properly print out config file to std error, and merge conventions such that m_new_config is used to store config file data Signed-off-by: Michael Maurer <[email protected]>
maurermi
force-pushed
the
config_generation
branch
2 times, most recently
from
af9767c
to
2833dce
Compare
Also updates config generation test to reflect previous behavior, would be good to review if this behavior is still appropriate however. Signed-off-by: Michael Maurer <[email protected]>
maurermi
force-pushed
the
config_generation
branch
from
2833dce
to
d237524
Compare
This PR looks to help complete #138 by making the changes requested in the most recent review. Namely, this change redirects the config file output to
stdout, and confines all other other messages tostderr. In addition, adds changes which reflect current naming conventions and design choices.