Demo guide on running Uniswap V3 on PArSEC #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurermi
requested changes
Aug 21, 2023
There was a problem hiding this comment.
T-ACK. Uniswap on OpenCBDC!! This was fun to play with and appears to work as expected. Very excited to see this. There are just a couple of typos in the uniswap_demo.md file that should be fixed, and I've also included some stylistic suggestions / nits that I'd at least like looked at, but are non-blockers.
See: docs/uniswap_demo/uniswap_demo.md Signed-off-by: Alexander Jung <[email protected]>
AlexRamRam
force-pushed
the
uniswapdemo
branch
from
4931bcd
to
833e338
Compare
maurermi
approved these changes
Aug 25, 2023
Thank you for going through this and contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: docs/uniswap_demo/uniswap_demo.md