Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aiming to improve readability of PArSEC (EVM) transaction flow #239

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Aiming to improve readability of PArSEC (EVM) transaction flow #239

wants to merge 6 commits into from

Commits on Oct 18, 2023

  1. Enhance http_server::handle_error() and make use of it 

    Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    43115b6 View commit details
    Browse the repository at this point in the history

  2. New http_server::make_agent() replaces a lambda 

    Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    837d6ec View commit details
    Browse the repository at this point in the history

  3. Rename to clarify both agent and broker's "begin" operations 

    The "begin" operations and states of both Agent and Broker are
explicitly acquisition of a new ticket number. Rename to clarify
this.

Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    20d3abd View commit details
    Browse the repository at this point in the history

  4. Replace std::visit/overloaded construct with if/else 

    Note that std::visit/overloaded construct is used throughout opencbdc.
Why change only this instance? The length of the std::visit block and
the fact that the variant is passed as the last argument at the end of
that block may place significant cognitive load on the reader.

Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2948d17 View commit details
    Browse the repository at this point in the history

  5. Improve clarity of nested callback flow by function name changes (PAr… 

    …SEC)

agent::impl
    do_start() --> do_start_function()
    handle_run() —> handle_run_result()
evm_runner
    run_execute_transaction() —> start_execute_transaction()
    handle_lock_from_account() —> handle_lockfromacct_and_continue_exec()
    lock_ticket_number_key() —> lock_ticket_number_key_and_continue_exec()

Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c813ffc View commit details
    Browse the repository at this point in the history

  6. Improve clarity of the final portion of evm_runner::exec() 

    Signed-off-by: Alexander Jung <[email protected]>
    @AlexRamRam
    AlexRamRam committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    9b303f3 View commit details
    Browse the repository at this point in the history