Add sumif function #1301
Open
Add sumif function #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aarondr77
commented
Apr 8, 2024
mitosheet/mitosheet/public/v3/sheet_functions/misc_functions.py
Outdated
Show resolved
Hide resolved
mitosheet/mitosheet/public/v3/sheet_functions/number_functions.py
Outdated
Show resolved
Hide resolved
mitosheet/mitosheet/public/v3/sheet_functions/number_functions.py
Outdated
Show resolved
Hide resolved
mitosheet/mitosheet/public/v3/sheet_functions/number_functions.py
Outdated
Show resolved
Hide resolved
|
It would be nice if the pro spreadsheet functions were greyed out for non-pro users with a CTA.. but we can do that later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the SUMIF function as the first Pro spreadsheet function. It does not support the full SUMIF Excel-implementation, but it does support the most common use cases that we have seen:
=SUMIF(df2!Key:Key, 'A1', df2!Value:Value),=SUMIF(df2!Key:Key, 'Apple', df2!Value:Value)Using the function in the open source version throws the following error:
Testing
See the tests and add one
Documentation
We should add this to the docs as a pro function.