Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Golang in Dockerfile #2829

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Fix Golang in Dockerfile #2829

merged 5 commits into from
Oct 19, 2023

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Oct 5, 2023

Description

Supersedes #2802. Fixes the same issue with compiling Go. I also updated mentions of minimum required golang version. Ubuntu 23.04 is the earliest version with Go v1.19+, so switched to it as the base. However, it also gives an error when running pip outside of a virtual environment, so I added that to the Dockerfile as well. Finally, I got go errors about "no required module provides package" until I added the go mod commands.

Must be merged in tandem with mitre/sandcat#434.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran Caldera via Dockerfile.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

noperse and others added 3 commits September 15, 2023 03:29
Ubuntu 23.04 is earliest one with golang 1.19+ in its repositories.
Ubuntu 23.04 requires running python in virtual env.
@clenk clenk requested review from elegantmoose and djlawren October 5, 2023 17:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@elegantmoose elegantmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on linux. LGTM.

@elegantmoose elegantmoose merged commit 4643964 into master Oct 19, 2023
11 checks passed
@elegantmoose elegantmoose deleted the clenk/fix-dockerfile-golang branch October 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants