Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-4695] Fix Manx Console Error/Timing Error #2834

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

bleepbop
Copy link
Contributor

Description

For <= Python3.10, Manx would throw a JSON decoding console error due to the server receiving an empty message from the agent. The plugin would still work, but this message can be confusing for users. After adding a short sleep command between messages sent to the agent, the problem no longer occurs. I believe this is because the agent now has sufficient time to process both received messages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Reran manx agents before and after changes. Agents continue to work as expected with change, and no longer send empty JSON messages to the server (and consequentially, no longer cause console errors).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bleepbop bleepbop requested a review from clenk October 20, 2023 18:32
@clenk clenk requested a review from elegantmoose October 21, 2023 17:08
@elegantmoose elegantmoose merged commit e6d712b into master Oct 25, 2023
@elegantmoose elegantmoose deleted the bleepbop/virts-4695/resolve-manx-bugs branch October 25, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants