Uses a dedicated setting to generate the magma VITE_CALDERA_URL variable#2994
Conversation
035c0f1 to
021054b
Compare
djlawren
left a comment
There was a problem hiding this comment.
Tested on remote host and localhost. All good from my perspective.
We are considering how to effectively document the login bug and mitigation going forward, but that shouldn't block these changes.
021054b to
3784390
Compare
The generated .env file used "host" and "port" settings which were not suitable for client URL generation (they are HTTP server listening settings, not client URL components).
3784390 to
0626285
Compare
|
@djlawren We are deploying a caldera instance on EC2, trying to expose the GUI over the public IP - we ran into a lot of issues, which this MR should be fixing (we have a small similar patch which proves to be working). Could this please be merged asap, to facilitate other users and our deployment ? |
|
Opened corresponding documentation PRs: #3006, mitre/fieldmanual#126
Noted on the urgency, apologies for the delays here. On to @elegantmoose now to review and merge. |
|
@prose-leviathan My bad. |
Description
Fix proposal for issue #2984, using a dedicated setting to be properly transferred to the magma's
.envfile when using the--buildoption.The setting name can be changed if needed.
Note the related issue is linked to a more general topic about configuration variables: Separating server listening settings, (HTTP) client and contact (agent) ones.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally tested.
Checklist: