Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove failing quality test for unsupported, obsolete Python version #3104

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

rfulwell
Copy link
Contributor

@rfulwell rfulwell commented Dec 10, 2024

Description

Python 3.8 is no longer supported. See:
https://endoflife.date/python
This change simply removes the failing quality test from the GitHub Action related to that version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested by verifying that the old 3.8 quality test is no longer run in the automated pipeline.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@elegantmoose
Copy link
Contributor

@clenk you okay with this?

@elegantmoose elegantmoose requested a review from clenk December 18, 2024 19:35
@elegantmoose elegantmoose merged commit 4b57658 into mitre:master Dec 19, 2024
1 of 5 checks passed
@elegantmoose
Copy link
Contributor

Good catch @rfulwell , TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants