Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to VITE_CALDERA_URL #3115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daw1012345
Copy link

@daw1012345 daw1012345 commented Dec 26, 2024

Related to the removal for VITE_CALDRA_URL in the magma repository in favor of using window.location.origin. Depends on mitre/magma#67. magma must be re-pinned.

Description

See the PR in the magma repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

System testing on a local instance (browsing and interacting with the UI).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • [DOES NOT APPLY] I have added tests that prove my fix is effective or that my feature works

Related to the removal for VITE_CALDRA_URL in the magma repository in favor of using window.location.origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant