Skip to content

Commit

Permalink
lodash returns better types, so fixed a type problem that was discovered
Browse files Browse the repository at this point in the history
Signed-off-by: Amndeep Singh Mann <[email protected]>
  • Loading branch information
Amndeep7 committed Jul 30, 2024
1 parent aa72d48 commit 6f2fa7f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion apps/frontend/src/components/cards/EvaluationInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ export default class EvaluationInfo extends Vue {
}
get duration(): string | undefined {
return _.get(this.file_object, 'evaluation.data.statistics.duration');
const duration = _.get(this.file_object, 'evaluation.data.statistics.duration');

Check warning on line 105 in apps/frontend/src/components/cards/EvaluationInfo.vue

View workflow job for this annotation

GitHub Actions / build

Replace `this.file_object,·'evaluation.data.statistics.duration'` with `⏎······this.file_object,⏎······'evaluation.data.statistics.duration'⏎····`

Check warning on line 105 in apps/frontend/src/components/cards/EvaluationInfo.vue

View workflow job for this annotation

GitHub Actions / build

Replace `this.file_object,·'evaluation.data.statistics.duration'` with `⏎······this.file_object,⏎······'evaluation.data.statistics.duration'⏎····`
return duration === null || duration == undefined ? undefined : duration.toString();

Check warning on line 106 in apps/frontend/src/components/cards/EvaluationInfo.vue

View workflow job for this annotation

GitHub Actions / build

Replace `·?·undefined` with `⏎······?·undefined⏎·····`

Check warning on line 106 in apps/frontend/src/components/cards/EvaluationInfo.vue

View workflow job for this annotation

GitHub Actions / build

Replace `·?·undefined` with `⏎······?·undefined⏎·····`
}
get evaluation(): IEvaluation | undefined {
Expand Down

0 comments on commit 6f2fa7f

Please sign in to comment.