Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unicode Support for Exports #5889

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add Unicode Support for Exports #5889

wants to merge 7 commits into from

Conversation

charleshu-8
Copy link
Contributor

@charleshu-8 charleshu-8 commented Jun 5, 2024 •
edited
Loading

  • Add Unicode support to HTML export
  • Add Unicode support to CSV export
  • Check other exports for Unicode support

@charleshu-8
HTML export UTF-8 fix
8aec75a 
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 added bug Something isn't working heimdall-frontend Issue is related to the Heimdall-Lite frontend labels Jun 5, 2024
@charleshu-8 charleshu-8 self-assigned this Jun 5, 2024
@charleshu-8 charleshu-8 marked this pull request as draft June 5, 2024 16:53
@charleshu-8 charleshu-8 linked an issue Jun 5, 2024 that may be closed by this pull request
[BUG] HTML and CSV exports do not support non-ascii properly #5872
Open
@charleshu-8 charleshu-8 changed the title Add UTF-8 Support for Exports Add Unicode Support for Exports Jun 5, 2024
@charleshu-8
Unicode CSV export fix
b80f396 
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 marked this pull request as ready for review June 5, 2024 19:32
Amndeep7
Amndeep7 requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for these exports and utf-8 characters

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@charleshu-8
Copy link
Contributor Author

Probably want to wait on #5910 and move the injected BOM to OHDF Converters side of things.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@charleshu-8 charleshu-8 marked this pull request as draft July 23, 2024 17:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@charleshu-8 charleshu-8

Labels
bug Something isn't working heimdall-frontend Issue is related to the Heimdall-Lite frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HTML and CSV exports do not support non-ascii properly
2 participants
@charleshu-8 @Amndeep7