Aamohd/file based config

[aamohd]

No description provided.

[j-lanson]

As I mentioned in one of the requested changes, we shouldn't take./config/Exec.kdl as the backup location for the exec file, it should just be Exec.kdl. But in git version control we are storing the file at ./config/Exec.kdl, which means people would need to pass --exec every time they want to run Hipcheck.

I think the solution is that everyone developing on Hipcheck copies ./config/Exec.kdl to ./Exec.kdl at the project root so it gets picked up as the default location, and this will be everyone's personal Exec.kdl file that doesn't get tracked in git. We can also add a rule to the .gitignore to ensure no root-level Exec.kdl file gets commited.

@alilleybrinker thoughts? or should the "config" folder be un-deprecated as a concept and use the resolution of the config dir to determine the expected location of the Exec.kdl file?

[j-lanson]

@aamohd, you'll also have to rebase off of main and address the cli.rs conflict

[j-lanson]

Just a couple more things, but looking good!

[j-lanson]

Don't forget to squash your commits into one to pass the CI check

[j-lanson]

Please carefully check for any remaining erroneous uses of unwrap().

[j-lanson]

One additional change (file rename), and previous comment has not been addressed yet.

[j-lanson]

Squash down to one commit and we're probably good to go

[j-lanson]

Can you please rebase off of main? Also, Rust 1.84 released today and our CI automatically uses it so you might see new clippy warnings in the CI that cause a test failure. You will need to fix those locally if they appear.