Feature - Manage schedules (3/3) #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
uruwhy
reviewed
Oct 17, 2024
- Add the CreateScheduleModal and DeleteScheduleModal - Add the two showmodals option in the CoreDisplayStore Fix the reset values and validation error message when creating schedule
- Add the SchedulesView.js - Add the view to the rooter - Add the view to the navigation
sasirven
force-pushed
the
feature/manage-schedules
branch
from
cbce191 to
b7a0c61
Compare
|
Hello @uruwhy can you check on this MR? |
uruwhy
approved these changes
Dec 4, 2024
elegantmoose
reviewed
Dec 4, 2024
| .field-label.is-normal | ||
| label.label Schedule | ||
| .field-body | ||
| input.input(placeholder="Schedule" v-model="schedule") |
There was a problem hiding this comment.
@sasirven Could we make the placeholder string hint at the crontab format required here?
|
Testing now. So far looks great! |
|
This LGTM. I just would like the default string hint for crontab format. |
elegantmoose
approved these changes
Dec 9, 2024
Hello sorry for the delay and thanks for the commit 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the GUI part of the schedules management with cron, which depends on the mitre/caldera#3025 and mitre/caldera#3026
Linked Merge Requests:
mitre/caldera#3025
mitre/caldera#3026